Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14138

Fix commented-out RequestLog in jetty.xml to use non-deprecated class

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.5
    • Component/s: None
    • Labels:
      None

      Description

      Currently the jetty request logging is disabled (commented out).

      But it can be useful, e.g. since it uses a standard logging format and there are tools to analyze it by default. Also it can be used to detect some attacks not otherwise logged anywhere else, since they don't make it to solr servlet: requests blocked at the jetty level (invalid/malformed requests, ones filtered by jetty IP filtering, etc).

      We should switch it from the deprecated NCSARequestLog class, instead to use the CustomRequestLog with either NCSA_FORMAT or EXTENDED_NCSA_FORMAT.

      Deprecated.
      use CustomRequestLog given format string CustomRequestLog.EXTENDED_NCSA_FORMAT with a RequestLogWriter

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              rcmuir Robert Muir
              Reporter:
              rcmuir Robert Muir

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h

                  Issue deployment