Solr
  1. Solr
  2. SOLR-141

Errors/Exceptions should be formated by ResponseWriter

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      Whenever possible, the Solr Dispatcher should to let the ResponseWriter format Exceptions using the format the user expects – this should in no way change the fact that Exceptions currently generate non 200 HTTP status codes, nor should it prevent the Dispatcher from using the exception message as the HTTP status message – but clients that want the full details of the error should be able to parse them in the format they expected based on the request.

      this would also give RequestHandlers the oportunity to return "partial" results - by adding both whatever results they have to the Response as well as the Exception they encountered.

      situations where this can't happen are obviously:

      • Exception thrown by ResponseWriter
      • Exception thrown so early in the request thta the DIspather doesn't know which ResposneWriter the client wanted.
        ...in those cases, plain text is a wise choice.

      thing that would probably need to be done to make this work:
      1) if the Dispatcher catches an exception, it should call SolrQueryResponse.setException, set the HTTP status code/message as it currently does, but then hand off to the ResponseWriter.
      2) Dispatcher needs to check SolrQueryResponse.getException and set the HTTP status code/message just like if it caught the exception itself.
      3) all of the ResponseWriters should start looking at SolrQueryResponse.getException if they aren't already, and formatting it in a usefull way.
      4) if the ResponseWriter throws an exception, Dispatcher needs to return a nice plain text error page

      extension to this idea... add a new method to ResponseWriter to generate a generic error message in the appropriate format that Dispatcher can use if the ResponseWriter throws an exception (as a backup before resorting to plain text)

      1. solr-exception-writer-v3.diff
        17 kB
        Daniel Naber
      2. solr-exception-writer-v2.diff
        16 kB
        Daniel Naber
      3. solr-exception-writer-solr-1.2.diff
        18 kB
        Daniel Naber
      4. SOLR-141-sendError.patch
        0.7 kB
        Rich Cariens
      5. SOLR-141-sendError.patch
        15 kB
        Ryan McKinley
      6. SOLR-141-3.x-Backport.patch
        19 kB
        Greg Bowyer
      7. error-response.patch
        5 kB
        Mike Sokolov

        Issue Links

          Activity

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Hoss Man
            • Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development