Solr
  1. Solr
  2. SOLR-1405

Show the index files in the web UI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: 1.4
    • Fix Version/s: 3.2
    • Component/s: web gui
    • Labels:
      None

      Description

      It would be great to view the actual index files from the web console.

      1. SOLR-1405.patch
        2 kB
        Juan Pedro Danculovic
      2. SOLR-1405.patch
        6 kB
        Juan Pedro Danculovic
      3. Index file list.png
        186 kB
        Juan Pedro Danculovic
      4. data menu.png
        150 kB
        Juan Pedro Danculovic

        Activity

        Hide
        Noble Paul added a comment -

        DO you mean just the information of an ls -l to be shown on the screen ?

        Show
        Noble Paul added a comment - DO you mean just the information of an ls -l to be shown on the screen ?
        Hide
        Jason Rutherglen added a comment -

        Noble, Somewhat like the information "ls -l" shows. Name, size, date would be good for starters.

        Show
        Jason Rutherglen added a comment - Noble, Somewhat like the information "ls -l" shows. Name, size, date would be good for starters.
        Hide
        Hoss Man added a comment -

        Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

        A unique token for finding these 240 issues in the future: hossversioncleanup20100527

        Show
        Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
        Hide
        Juan Pedro Danculovic added a comment -

        This patch solves this issue.

        I've attached two screenshots to show the data menu and the index file info details

        Juan

        Show
        Juan Pedro Danculovic added a comment - This patch solves this issue. I've attached two screenshots to show the data menu and the index file info details Juan
        Hide
        Hoss Man added a comment -

        There's a general concensus that we should stop adding new JSPs to the admin interface (or enhancing existing JSPs) and we should instead use RequestHandlers to return this type of information – that way it can be more easily consumed by client libraries or AJAX based requests, and styled using XSLT.

        in particular: the SystemInfoHandler is replacing the registry.jsp and stats.jsp.

        While we could certainly add this to the SystemInfoRequestHandler it seems like it might make sense as part of hte LukeRequestHandler (using a new "files" value for the "show" param)

        Unrelated note: We should also try to make sure we respect the Directory abstraction (don't assume all files are related to the index) and we have to be aware of hte whole IndexReaderFactory thing (so the directory may not even be used) ... i don't know that we have to do anything special in that case, but we should at least sanity check that the combination of the two doesn't break anything

        Show
        Hoss Man added a comment - There's a general concensus that we should stop adding new JSPs to the admin interface (or enhancing existing JSPs) and we should instead use RequestHandlers to return this type of information – that way it can be more easily consumed by client libraries or AJAX based requests, and styled using XSLT. in particular: the SystemInfoHandler is replacing the registry.jsp and stats.jsp. While we could certainly add this to the SystemInfoRequestHandler it seems like it might make sense as part of hte LukeRequestHandler (using a new "files" value for the "show" param) Unrelated note: We should also try to make sure we respect the Directory abstraction (don't assume all files are related to the index) and we have to be aware of hte whole IndexReaderFactory thing (so the directory may not even be used) ... i don't know that we have to do anything special in that case, but we should at least sanity check that the combination of the two doesn't break anything
        Hide
        Andrzej Bialecki added a comment -

        .. in particular ParallelReader.directory() throws UnsupportedOperationException, so such cases should be handled too.

        Show
        Andrzej Bialecki added a comment - .. in particular ParallelReader.directory() throws UnsupportedOperationException, so such cases should be handled too.
        Hide
        Jason Rutherglen added a comment -

        general concensus that we should stop adding new JSPs to the admin interface

        Makes sense... I'll update my ZK related patch accordingly.

        Also, ReplicationHandler shows the index files as well.

        Show
        Jason Rutherglen added a comment - general concensus that we should stop adding new JSPs to the admin interface Makes sense... I'll update my ZK related patch accordingly. Also, ReplicationHandler shows the index files as well.
        Hide
        Yonik Seeley added a comment -

        There's a general concensus that we should stop adding new JSPs to the admin interface (or enhancing existing JSPs) and we should instead use RequestHandlers to return this type of information

        Hmmm, really?

        I've not opposed to people converting JSPs to something else (when the functionality is not diminished), but I'm certainly against a JSP moratorium without very good reason. Sometimes it's just a much easier way to expose simple information that's primarily meant for human consumption (and when there is a patch in hand).

        Progress, not perfection

        Show
        Yonik Seeley added a comment - There's a general concensus that we should stop adding new JSPs to the admin interface (or enhancing existing JSPs) and we should instead use RequestHandlers to return this type of information Hmmm, really? I've not opposed to people converting JSPs to something else (when the functionality is not diminished), but I'm certainly against a JSP moratorium without very good reason. Sometimes it's just a much easier way to expose simple information that's primarily meant for human consumption (and when there is a patch in hand). Progress, not perfection
        Hide
        Hoss Man added a comment -

        Hmmm, really?

        it's a recurring theme that keeps coming up over and over - i actually thought you were the person who originally started pushing for it.

        Sometimes it's just a much easier way to expose simple information that's primarily meant for human consumption (and when there is a patch in hand).

        Fair enough ... but at this point we already have the SystemInfoRequestHandler which eliminates the need for stats.jsp or registry.jsp (which is what this patch updates) ... so i'd rather not add more functionality to either of those JSP.

        Show
        Hoss Man added a comment - Hmmm, really? it's a recurring theme that keeps coming up over and over - i actually thought you were the person who originally started pushing for it. Sometimes it's just a much easier way to expose simple information that's primarily meant for human consumption (and when there is a patch in hand). Fair enough ... but at this point we already have the SystemInfoRequestHandler which eliminates the need for stats.jsp or registry.jsp (which is what this patch updates) ... so i'd rather not add more functionality to either of those JSP.
        Hide
        Juan Pedro Danculovic added a comment - - edited

        I didn't know about the idea of stop adding code into jsp pages
        I can change the patch and add the index files information into the SystemInfoRequestHandler. Is this ok?
        Sorry about my mistake.

        Show
        Juan Pedro Danculovic added a comment - - edited I didn't know about the idea of stop adding code into jsp pages I can change the patch and add the index files information into the SystemInfoRequestHandler. Is this ok? Sorry about my mistake.
        Hide
        Hoss Man added a comment -

        Juan: no apologies neccessary, you made no mistake – i was just sharing my opinions on the subject.

        I was just looking at SOLR-1750 with the intent of finishing it up and merging your patch into that handler, when i realized it may not the best place either (there is already another SystemInfoHandler so i think SystemInfoRequestHandler should narrow it's focus to just be about returning the lists of SolrInfoMBean's w/stats)

        If you want to tweak the patch to updated either the LukeRequestHandler or the SystemInfoHandler feel free – i'm not honestly sure where it makes the most sense at this point.

        Show
        Hoss Man added a comment - Juan: no apologies neccessary, you made no mistake – i was just sharing my opinions on the subject. I was just looking at SOLR-1750 with the intent of finishing it up and merging your patch into that handler, when i realized it may not the best place either (there is already another SystemInfoHandler so i think SystemInfoRequestHandler should narrow it's focus to just be about returning the lists of SolrInfoMBean's w/stats) If you want to tweak the patch to updated either the LukeRequestHandler or the SystemInfoHandler feel free – i'm not honestly sure where it makes the most sense at this point.
        Hide
        Juan Pedro Danculovic added a comment -

        I think that LukeRequestHandler is better than SystemInfoHandler because index files are closer to lucene but it is true that is a thin line to determine where the issue suites best.

        I can try to add it to LukeRH. Are you agree?

        Show
        Juan Pedro Danculovic added a comment - I think that LukeRequestHandler is better than SystemInfoHandler because index files are closer to lucene but it is true that is a thin line to determine where the issue suites best. I can try to add it to LukeRH. Are you agree?
        Hide
        Juan Pedro Danculovic added a comment -

        The last patch adds index files information into LukeRequestHandler and also includes the test.

        Show
        Juan Pedro Danculovic added a comment - The last patch adds index files information into LukeRequestHandler and also includes the test.
        Hide
        Jason Rutherglen added a comment -

        Sorry if this spam's things, however it's unlikely that I'll work on these.

        Show
        Jason Rutherglen added a comment - Sorry if this spam's things, however it's unlikely that I'll work on these.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jason Rutherglen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development