[SOLR-14048] Improve Hadoop test sanity checks

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.5
• Component/s: Hadoop Integration, hdfs, Tests
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 10/Dec/19 20:57
• Updated: 24/Mar/20 12:45
• Resolved: 13/Dec/19 03:44

Description

Add more checks around the Hadoop modified classes we use.

Some ideas from hossman in SOLR-14033

• some dev docs (package level javadocs?) explaining the whole org.apache.hadoop "shadow" class impls
• ideally include some hook in HdfsTestUtil that causes it to fail fast if it can detect that the classloader didn't pick up our modified classes? .. maybe by adding a new public static final Object SOLR_HACK_FOR_CLASS_VERIFICATION = new Object to each org.apache.hadoop.** that it could check for via reflection?

Issue Links

• relates to: SOLR-14033 Fix Hadoop tests with security manager
• relates to: SOLR-14047 Make sure tests don't pickup other Hadoop installs
• links to: GitHub Pull Request #1076