[SOLR-14042] Fix 7 Varargs methods should only override or be overridden by other varargs methods warnings

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.5, 9.0
• Assignee: Jason Gerlowski
• Reporter: Andras Salamon
• Created: 10/Dec/19 14:47
• Updated: 24/Mar/20 12:46
• Resolved: 19/Dec/19 15:16

Description

Precommit lists 7 quite similar varargs related warnings:

[ecj-lint] 1. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/ConcatEvaluator.java (at line 46)
 [ecj-lint]     public Object doWork(Object values[]) throws IOException {
 [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike ConcatEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
--
 [ecj-lint] 2. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DateEvaluator.java (at line 44)
 [ecj-lint]     public Object doWork(Object values[]) throws IOException {
 [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike DateEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
--
 [ecj-lint] 3. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DbscanEvaluator.java (at line 44)
 [ecj-lint]     public Object doWork(Object values[]) throws IOException {
 [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike DbscanEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
--
 [ecj-lint] 4. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/EmpiricalDistributionEvaluator.java (at line 41)
 [ecj-lint]     public Object doWork(Object[] values) throws IOException {
 [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike EmpiricalDistributionEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
--
 [ecj-lint] 5. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java (at line 39)
 [ecj-lint]     public Object doWork(Object[] values) throws IOException {
 [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike MatchesEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)
--
 [ecj-lint] 6. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java (at line 39)
 [ecj-lint]     public Object doWork(Object[] values) throws IOException {
 [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike MatchesEvaluator.doWork(Object[]) and RecursiveBooleanEvaluator.doWork(Object...)
--
 [ecj-lint] 7. WARNING in /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/PivotEvaluator.java (at line 45)
 [ecj-lint]     public Object doWork(Object[] values) throws IOException {
 [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] Varargs methods should only override or be overridden by other varargs methods unlike PivotEvaluator.doWork(Object[]) and ManyValueWorker.doWork(Object...)