[SOLR-13952] Added SuppressWarnings and similar minor matters

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: Build
• Assignee: Erick Erickson
• Reporter: Erick Erickson
• Created: 21/Nov/19 13:34
• Updated: 21/Jan/20 16:59
• Resolved: 25/Nov/19 20:13

Description

The gradle_8 branch has many changes unrelated to gradle. It would be much easier to work on the gradle parts if these were separated. So here's my plan:

This turned out not to be as hard as I expected. I'll create a sub-task for the functional changes and use this one for the non-functional changes. Non-functional changes are the overwhelming majority of changes. There are a few categories of change here:

• SuppressWarnings, rawtypes, deprecated.
• SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter and QuickPatchThreadsFilter. These are know thread leaks from third-party products (IBM Java, and a Log4J2 thread was added)
• some static imports were removed
• some reformatting, given that this whole patch is not about functional changes I decided to leave them in.
• Some very minor code changes:
  • change "new Path(leaderPath).getParent().toString();" to "Paths.get(leaderPath).getParent().toString();"
  • mods like new HashMap(); <- new HashMap<>();
• Log messages added

Issue Links

• incorporates: SOLR-13964 Separate out functional changes from the gradle_8 branch unrelated to the Gradle build
• is part of: SOLR-13914 Umbrella issue for updating the build system to use Gradle