Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13952

Added SuppressWarnings and similar minor matters

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Build
    • Labels:
      None

      Description

      The gradle_8 branch has many changes unrelated to gradle. It would be much easier to work on the gradle parts if these were separated. So here's my plan:

      This turned out not to be as hard as I expected. I'll create a sub-task for the functional changes and use this one for the non-functional changes. Non-functional changes are the overwhelming majority of changes. There are a few categories of change here:

      • SuppressWarnings, rawtypes, deprecated.
      • SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter and QuickPatchThreadsFilter. These are know thread leaks from third-party products (IBM Java, and a Log4J2 thread was added)
      • some static imports were removed
      • some reformatting, given that this whole patch is not about functional changes I decided to leave them in.
      • Some very minor code changes:
        • change "new Path(leaderPath).getParent().toString();" to "Paths.get(leaderPath).getParent().toString();"
        • mods like new HashMap(); <- new HashMap<>();
      • Log messages added

        Attachments

        1. SOLR-13952.patch
          353 kB
          Erick Erickson
        2. fordavid.patch
          0.6 kB
          Erick Erickson

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                erickerickson Erick Erickson
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: