Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13868 Eliminate 'Port Roulette' in Solr Testing
  3. SOLR-13870

eliminate getNextAvailablePort() dependency in SolrJmxReporterTest

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.4, main (9.0)
    • Component/s: None
    • Labels:
      None

      Description

      SolrJmxReporterTest is currently the only solr test using (the problematic) SolrTestCaseJ4.getNextAvailablePort helper method in order to assign a RMI port for running a JMX server.

      This test doesn't actually care that it's using RMI for JMX, it only cares that:

      1. an MBeanServer is initialized that it can query
      2. that MBeanServer can be specified in the plugin configuration for the SolrJmxReporter

      We should cleanup the test initialization so that it no longer depends on RMI via the serviceUrl plugin configuration option, and instead just use the agentId to specify an MBeanServer bootstrapped by the test.

        Attachments

        1. SOLR-13870.patch
          9 kB
          Chris M. Hostetter

          Issue Links

            Activity

              People

              • Assignee:
                hossman Chris M. Hostetter
                Reporter:
                hossman Chris M. Hostetter
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: