[SOLR-13828] Improve ExecutePlanAction error handling

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.7.2, 8.2, 8.3
• Fix Version/s: 7.7.3, 8.3
• Component/s: AutoScaling
• Assignee: Andrzej Bialecki
• Reporter: Andrzej Bialecki
• Created: 08/Oct/19 18:34
• Updated: 21/Jan/20 16:56
• Resolved: 14/Oct/19 10:35

Description

There's a bug in ExecutePlanAction, where it's possible that in some situations it would create duplicate asyncId-s for events with multiple operations - unit tests didn't catch it probably because operations took shorter time than the default task timeout, which is 120 sec and this situation would arise if the task timeout was reached but the task was still running.

Also, error handling in ExecutePlanAction should be improved to correctly throw Exceptions when an operation fails to complete - it's possible now for an operation to fail yet the ExecutePlanAction to report success.

This also brings a question of the task timeout - currently it's not configurable, but it should be. It can be configured in the action properties.