[SOLR-13739] Managed resource observers have to be added only once

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.0, 8.1, 8.1.1, 8.2, 9.0
• Fix Version/s: 8.3
• Component/s: Server
• Labels: easyfix performance pull-request-available ready-to-commit
• Assignee: David Smiley
• Reporter: Thomas Wöckinger
• Created: 04/Sep/19 08:49
• Updated: 21/Jan/20 16:57
• Resolved: 13/Sep/19 16:37

Description

On huge schema modifications, mostly happen due to creation of a new collection, the same observer instance of an ResourceLoaderAware component is added again and again.

This leads to a runtime behaviour of n²/2 where n is is the number of schema operation multiplied by ResourceLoaderAware components instead of the number of containing ResourceLoaderAware components.

E.g. If you have 1000 schema operations and 2 ResourceLoaderAware components this leads to 500000 operations instead of 2000.

Even worse the corresponding resource is registered again and again, which can take some time e.g. ManagedSynonymGraphFilterFactory needs about 5s on each call (depending on the size of synonyms).

Issue Links

• links to: GitHub Pull Request #855