[SOLR-13699] maxChars no longer working on CopyField with Javabin

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.7, 7.7.1, 7.7.2, 7.7.3, 8.0, 8.1, 8.1.1, 8.1.2, 8.2
• Fix Version/s: 8.3
• Assignee: Noble Paul
• Reporter: Chris Troullis
• Created: 15/Aug/19 18:20
• Updated: 21/Jan/20 16:59
• Resolved: 25/Aug/19 23:02

Description

We recently upgraded from Solr 7.3 to 8.1, and noticed that the maxChars property on a copy field is no longer functioning as designed, while indexing via SolrJ. Per the most recent documentation it looks like there have been no intentional changes as to the functionality of this property, so I assume this is a bug.
 
In debugging the issue, it looks like the bug was caused by SOLR-12992. In DocumentBuilder where the maxChar limit is applied, it first checks if the value is instanceof String. As of SOLR-12992, string values are now coming in as ByteArrayUtf8CharSequence (unless they are above a certain size as defined by JavaBinCodec.MAX_UTF8_SZ), so they are failing the instanceof String check, and the maxChar truncation is not being applied. 

 

The issue seems to be limited to Javabin, docs indexed in other formats (where values come in as strings) are working fine.

Issue Links

• links to: GitHub Pull Request #845