[SOLR-13542] Code cleanup - Avoid using stream filter count where possible

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 8.3, 9.0
• Component/s: SolrJ
• Assignee: Unassigned
• Reporter: Koen De Groote
• Created: 12/Jun/19 23:59
• Updated: 12/May/22 00:26
• Resolved: 27/Aug/19 22:28

Description

This is another ticket in the logic of https://issues.apache.org/jira/browse/LUCENE-8847

 

Not a feature, not serious, don't review this when you could be reviewing actual features or critical bugs, don't want to take your time away with this.

 

Intellij's static code analysis bumped into this.

 

I also saw most other instances in the code where such a filter needed to happen already used

anyMatch

instead of count(). So I applied the suggested fixes. Code cleanup and potentially a small performance gain. As far as my understanding goes, since it is not a simple count that's happening, there's no known size for the evaluator to return and as such it has to iterate over the entire collection. Whereas anyMatch and noneMatch will use the predicate to stop the instance the condition is met.

It just so happens that all affected instances exist within the SolrJ namespace.

 

All tests have run, all succeed.

 

EDIT: Github PR: https://github.com/apache/lucene-solr/pull/717

Issue Links

• links to: GitHub Pull Request #717