Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13400

Replace Observable pattern in TransientSolrCoreCache

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 8.0, master (9.0)
    • Fix Version/s: 8.1, master (9.0)
    • Component/s: Server, SolrCloud
    • Labels:
      None

      Description

      Due to change to Java 11 as minimum version (LUCENE-8738), the usage of the old java.utilObservable pattern is deprecated and cannot be used anymore in Lucene/Solr.

      LUCENE-8738 added a rewritten, more type-safe oimplementation of the observer pattern, but it looks like the is overengenieered. As there is only one listener registered, it would be enough to just call the method on SolrCores class (pkg-protected). On LUCENE-8738, Erick Erickson suggested to move the callback method to queue closes of core in CoreContainer instead, so all the abstractions can be removed.

        Attachments

        1. SOLR-13400-master.patch
          9 kB
          Erick Erickson
        2. SOLR-13400-8x.patch
          8 kB
          Erick Erickson
        3. SOLR-13400.patch
          7 kB
          Erick Erickson

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                uschindler Uwe Schindler
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: