[SOLR-13243] Correct initial capacity of ops

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 7.7
• Fix Version/s: main (10.0), 9.2
• Assignee: Kevin Risden
• Reporter: hu xiaodong
• Created: 12/Feb/19 09:26
• Updated: 27/Mar/23 18:04
• Resolved: 10/Jan/23 20:51

Description

ElectionContext.java

@Override
void runLeaderProcess(boolean weAreReplacement, int pauseBeforeStartMs)
throws KeeperException, InterruptedException, IOException {

String parent = new Path(leaderPath).getParent().toString();
try {
RetryUtil.retryOnThrowable(NodeExistsException.class, 60000, 5000, () -> {
synchronized (lock) {
........


List<Op> ops = new ArrayList<>(2);       //HERE SHOULD BE 3 OR MORE



ops.add(Op.check(leaderSeqPath, -1));
ops.add(Op.create(leaderPath, Utils.toJSON(leaderProps), zkClient.getZkACLProvider().getACLsToAdd(leaderPath), CreateMode.EPHEMERAL));
ops.add(Op.setData(parent, null, -1));
List<OpResult> results;

results = zkClient.multi(ops, true);
.......
}

 

Issue Links

• is related to: SOLR-15446 fix some off-by-one initialCapacity choices when calling ZooKeeper.multi
• links to: GitHub Pull Request #1232