Solr
  1. Solr
  2. SOLR-1323

XPathEntityProcessor's $hasMore feature should reset when fetching the next URL

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      See http://www.lucidimagination.com/search/document/4e266fd420ae5826/dataimporthandler_xpathentityprocessor_hasmore_infinite_loop

      Currently if $hasMore is set on a row, it must be reset manually in order for the next URL to not be requested.

      It makes more sense for XPathEntityProcessor to reset the $hasMore flag when processed.

      1. SOLR-1323.patch
        2 kB
        Noble Paul
      2. SOLR-1323.patch
        0.9 kB
        Erik Hatcher

        Activity

        Hide
        Erik Hatcher added a comment -

        simple patch to simply set $hasMore to false once it is processed. The scenario mentioned in the e-mail thread is alleviated with this patch. That's the extent of my testing. Anyone see anything wrong? If not, I'll commit in a few days.

        Show
        Erik Hatcher added a comment - simple patch to simply set $hasMore to false once it is processed. The scenario mentioned in the e-mail thread is alleviated with this patch. That's the extent of my testing. Anyone see anything wrong? If not, I'll commit in a few days.
        Hide
        Noble Paul added a comment -

        it should be removed , instead of setting to false. $nextUrl also can be removed along with it

        Show
        Noble Paul added a comment - it should be removed , instead of setting to false. $nextUrl also can be removed along with it
        Hide
        Erik Hatcher added a comment -

        Committed. Thanks for the tweak, Noble.

        Show
        Erik Hatcher added a comment - Committed. Thanks for the tweak, Noble.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development