Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13181

NullPointerException in org.apache.solr.request.macro.MacroExpander

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: master (9.0)
    • Fix Version/s: 8.7
    • Component/s: None
    • Labels:
    • Environment:

      Description

      Requesting the following URL causes Solr to return an HTTP 500 error response:

      http://localhost:8983/solr/films/select?a=${${b}}
      

      The error response seems to be caused by the following uncaught exception:

      java.lang.StringIndexOutOfBoundsException: String index out of range: -4
      	at java.lang.String.substring(String.java:1967)
      	at org.apache.solr.request.macro.MacroExpander._expand(MacroExpander.java:150)
      	at org.apache.solr.request.macro.MacroExpander.expand(MacroExpander.java:101)
      	at org.apache.solr.request.macro.MacroExpander.expand(MacroExpander.java:65)
      	at org.apache.solr.request.macro.MacroExpander.expand(MacroExpander.java:51)
      	at org.apache.solr.request.json.RequestUtil.processParams(RequestUtil.java:159)
      	at org.apache.solr.util.SolrPluginUtils.setDefaults(SolrPluginUtils.java:167)
      	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:196)
      [...]
      

      Parameter macro expansion seems to take place in org.apache.solr.request.macro.MacroExpander._expand(String val). From reading the code of the function it seems that macros are not expanded inside curly brackets ${...}, and so the ${b} inside

      ${${b}}
      

      should not be expanded. But the function seems to fail to detect this specific case and graciously refuse to expand it.

      A possible fix could be updating the idx variable when the StrParser detects that no valid identifier can be found inside the brackets. See attached file 0001-Macro-expander-fail-gracefully-on-unsupported-syntax.patch.

      We found this bug using Diffblue Microservices Testing. Find more information on this fuzz testing campaign.

        Attachments

        1. home.zip
          376 kB
          Cesar Rodriguez
        2. SOLR-13181.patch
          0.9 kB
          Cesar Rodriguez

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                cesar.rodriguez Cesar Rodriguez
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 10m
                  3h 10m