Solr
  1. Solr
  2. SOLR-1300

need to exlcude downloaded clustering libs from release packages

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      As noted by grant...

      http://www.nabble.com/Re%3A-cleaning-up-example-p24469638.html

      the build file for the clustering contrib downloads some optional jars that can't be included in the release. Yonik/Hoss simplified the build files, but as a side effect all libs are included in the dist (even the ones that shouldn't be)

      we need to exclude them (one way or another) before we release 1.4.

        Issue Links

          Activity

          Hoss Man created issue -
          Hide
          Grant Ingersoll added a comment -

          Hoss,

          Did you mean for clustering? if so, I fixed that, I believe, but the Release Manager will need to double check. I believe the Extraction libs are all good.

          Show
          Grant Ingersoll added a comment - Hoss, Did you mean for clustering? if so, I fixed that, I believe, but the Release Manager will need to double check. I believe the Extraction libs are all good.
          Hide
          Hoss Man added a comment -

          Doh! ... sorry, we have too many contribs i keep getting them confused.

          yes, i was talking about clustering not extraction (issue summary/description updated) and we do still have a problem...

          hossman@coaster:~/lucene/solr$ tar -ztf dist/apache-solr-1.4-dev.tgz | egrep pcj\|colt\|nni\|simple-xml
          apache-solr-1.4-dev/contrib/clustering/lib/colt-1.2.0.jar
          apache-solr-1.4-dev/contrib/clustering/lib/nni-1.0.0.jar
          apache-solr-1.4-dev/contrib/clustering/lib/pcj-1.2.jar
          apache-solr-1.4-dev/contrib/clustering/lib/simple-xml-1.7.3.jar
          
          Show
          Hoss Man added a comment - Doh! ... sorry, we have too many contribs i keep getting them confused. yes, i was talking about clustering not extraction (issue summary/description updated) and we do still have a problem... hossman@coaster:~/lucene/solr$ tar -ztf dist/apache-solr-1.4-dev.tgz | egrep pcj\|colt\|nni\|simple-xml apache-solr-1.4-dev/contrib/clustering/lib/colt-1.2.0.jar apache-solr-1.4-dev/contrib/clustering/lib/nni-1.0.0.jar apache-solr-1.4-dev/contrib/clustering/lib/pcj-1.2.jar apache-solr-1.4-dev/contrib/clustering/lib/simple-xml-1.7.3.jar
          Hoss Man made changes -
          Field Original Value New Value
          Summary need to exlcude downloaded extraction libs from release packages need to exlcude downloaded clustering libs from release packages
          Description As noted by grant...

          http://www.nabble.com/Re%3A-cleaning-up-example-p24469638.html

          the build file for the extraction contrib downloads some optional jars that can't be included in the release. Yonik/Hoss simplified the build files, but as a side effect *all* libs are included in the dist (even the ones that shouldn't be)

          we need to exlucde them (one way or another) before we release 1.4.
          As noted by grant...

          http://www.nabble.com/Re%3A-cleaning-up-example-p24469638.html

          the build file for the clustering contrib downloads some optional jars that can't be included in the release. Yonik/Hoss simplified the build files, but as a side effect *all* libs are included in the dist (even the ones that shouldn't be)

          we need to exclude them (one way or another) before we release 1.4.
          Grant Ingersoll made changes -
          Assignee Grant Ingersoll [ gsingers ]
          Hide
          Grant Ingersoll added a comment - - edited

          Hmm, part of the problem, I think, lies in:

          <tar destfile="${dist}/${fullnamever}.tgz" compression="gzip" longfile="gnu">
                <tarfileset dir="."
                  prefix="${fullnamever}"
                  includes="LICENSE.txt NOTICE.txt *.txt *.xml lib/** src/** example/** client/** contrib/"
                  excludes="lib/README.committers.txt **/data/ **/logs/* **/classes/ **/*.sh **/bin/ src/scripts/ src/site/build/ **/target/ client/ruby/flare/ client/python" />
                <tarfileset dir="."
                  mode="755"
                  prefix="${fullnamever}"
                  includes="**/*.sh **/bin/ src/scripts/" />
                <tarfileset dir="."
                  prefix="${fullnamever}"
                  includes="dist/**"
                  excludes="*.tgz *.zip *.md5 ${dist}/*src-* ${dist}/*docs-*" />
                <tarfileset dir="${build.docs}"
                  prefix="${fullnamever}/docs/" />
              </tar>
          

          Where we blindly include all of contrib. Still looking...

          Show
          Grant Ingersoll added a comment - - edited Hmm, part of the problem, I think, lies in: <tar destfile="${dist}/${fullnamever}.tgz" compression="gzip" longfile="gnu"> <tarfileset dir="." prefix="${fullnamever}" includes="LICENSE.txt NOTICE.txt *.txt *.xml lib/** src/** example/** client/** contrib/" excludes="lib/README.committers.txt **/data/ **/logs/* **/classes/ **/*.sh **/bin/ src/scripts/ src/site/build/ **/target/ client/ruby/flare/ client/python" /> <tarfileset dir="." mode="755" prefix="${fullnamever}" includes="**/*.sh **/bin/ src/scripts/" /> <tarfileset dir="." prefix="${fullnamever}" includes="dist/**" excludes="*.tgz *.zip *.md5 ${dist}/*src-* ${dist}/*docs-*" /> <tarfileset dir="${build.docs}" prefix="${fullnamever}/docs/" /> </tar> Where we blindly include all of contrib. Still looking...
          Grant Ingersoll made changes -
          Link This issue is part of SOLR-1433 [ SOLR-1433 ]
          Hide
          Grant Ingersoll added a comment -

          I just did a clean package and it seems like these are now taken care of on trunk

          Show
          Grant Ingersoll added a comment - I just did a clean package and it seems like these are now taken care of on trunk
          Grant Ingersoll made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Shalin Shekhar Mangar added a comment -

          I can still see the downloaded libs making their way into the release.

          Show
          Shalin Shekhar Mangar added a comment - I can still see the downloaded libs making their way into the release.
          Shalin Shekhar Mangar made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Grant Ingersoll added a comment -

          Did you clean everything out?

          Show
          Grant Ingersoll added a comment - Did you clean everything out?
          Hide
          Shalin Shekhar Mangar added a comment -

          Sorry, false alarm. I did a clean checkout and yes, these libs are not being included anymore.

          Show
          Shalin Shekhar Mangar added a comment - Sorry, false alarm. I did a clean checkout and yes, these libs are not being included anymore.
          Shalin Shekhar Mangar made changes -
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Resolved [ 5 ]
          Hide
          Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          Grant Ingersoll added a comment - Bulk close for Solr 1.4
          Grant Ingersoll made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          68d 14h 49m 1 Grant Ingersoll 28/Sep/09 16:30
          Resolved Resolved Reopened Reopened
          4h 40m 1 Shalin Shekhar Mangar 28/Sep/09 21:11
          Reopened Reopened Resolved Resolved
          39m 26s 1 Shalin Shekhar Mangar 28/Sep/09 21:50
          Resolved Resolved Closed Closed
          42d 19h 1m 1 Grant Ingersoll 10/Nov/09 15:52

            People

            • Assignee:
              Grant Ingersoll
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development