Solr
  1. Solr
  2. SOLR-1300

need to exlcude downloaded clustering libs from release packages

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      As noted by grant...

      http://www.nabble.com/Re%3A-cleaning-up-example-p24469638.html

      the build file for the clustering contrib downloads some optional jars that can't be included in the release. Yonik/Hoss simplified the build files, but as a side effect all libs are included in the dist (even the ones that shouldn't be)

      we need to exclude them (one way or another) before we release 1.4.

        Issue Links

          Activity

          Hide
          Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          Grant Ingersoll added a comment - Bulk close for Solr 1.4
          Hide
          Shalin Shekhar Mangar added a comment -

          Sorry, false alarm. I did a clean checkout and yes, these libs are not being included anymore.

          Show
          Shalin Shekhar Mangar added a comment - Sorry, false alarm. I did a clean checkout and yes, these libs are not being included anymore.
          Hide
          Grant Ingersoll added a comment -

          Did you clean everything out?

          Show
          Grant Ingersoll added a comment - Did you clean everything out?
          Hide
          Shalin Shekhar Mangar added a comment -

          I can still see the downloaded libs making their way into the release.

          Show
          Shalin Shekhar Mangar added a comment - I can still see the downloaded libs making their way into the release.
          Hide
          Grant Ingersoll added a comment -

          I just did a clean package and it seems like these are now taken care of on trunk

          Show
          Grant Ingersoll added a comment - I just did a clean package and it seems like these are now taken care of on trunk
          Hide
          Grant Ingersoll added a comment - - edited

          Hmm, part of the problem, I think, lies in:

          <tar destfile="${dist}/${fullnamever}.tgz" compression="gzip" longfile="gnu">
                <tarfileset dir="."
                  prefix="${fullnamever}"
                  includes="LICENSE.txt NOTICE.txt *.txt *.xml lib/** src/** example/** client/** contrib/"
                  excludes="lib/README.committers.txt **/data/ **/logs/* **/classes/ **/*.sh **/bin/ src/scripts/ src/site/build/ **/target/ client/ruby/flare/ client/python" />
                <tarfileset dir="."
                  mode="755"
                  prefix="${fullnamever}"
                  includes="**/*.sh **/bin/ src/scripts/" />
                <tarfileset dir="."
                  prefix="${fullnamever}"
                  includes="dist/**"
                  excludes="*.tgz *.zip *.md5 ${dist}/*src-* ${dist}/*docs-*" />
                <tarfileset dir="${build.docs}"
                  prefix="${fullnamever}/docs/" />
              </tar>
          

          Where we blindly include all of contrib. Still looking...

          Show
          Grant Ingersoll added a comment - - edited Hmm, part of the problem, I think, lies in: <tar destfile="${dist}/${fullnamever}.tgz" compression="gzip" longfile="gnu"> <tarfileset dir="." prefix="${fullnamever}" includes="LICENSE.txt NOTICE.txt *.txt *.xml lib/** src/** example/** client/** contrib/" excludes="lib/README.committers.txt **/data/ **/logs/* **/classes/ **/*.sh **/bin/ src/scripts/ src/site/build/ **/target/ client/ruby/flare/ client/python" /> <tarfileset dir="." mode="755" prefix="${fullnamever}" includes="**/*.sh **/bin/ src/scripts/" /> <tarfileset dir="." prefix="${fullnamever}" includes="dist/**" excludes="*.tgz *.zip *.md5 ${dist}/*src-* ${dist}/*docs-*" /> <tarfileset dir="${build.docs}" prefix="${fullnamever}/docs/" /> </tar> Where we blindly include all of contrib. Still looking...
          Hide
          Hoss Man added a comment -

          Doh! ... sorry, we have too many contribs i keep getting them confused.

          yes, i was talking about clustering not extraction (issue summary/description updated) and we do still have a problem...

          hossman@coaster:~/lucene/solr$ tar -ztf dist/apache-solr-1.4-dev.tgz | egrep pcj\|colt\|nni\|simple-xml
          apache-solr-1.4-dev/contrib/clustering/lib/colt-1.2.0.jar
          apache-solr-1.4-dev/contrib/clustering/lib/nni-1.0.0.jar
          apache-solr-1.4-dev/contrib/clustering/lib/pcj-1.2.jar
          apache-solr-1.4-dev/contrib/clustering/lib/simple-xml-1.7.3.jar
          
          Show
          Hoss Man added a comment - Doh! ... sorry, we have too many contribs i keep getting them confused. yes, i was talking about clustering not extraction (issue summary/description updated) and we do still have a problem... hossman@coaster:~/lucene/solr$ tar -ztf dist/apache-solr-1.4-dev.tgz | egrep pcj\|colt\|nni\|simple-xml apache-solr-1.4-dev/contrib/clustering/lib/colt-1.2.0.jar apache-solr-1.4-dev/contrib/clustering/lib/nni-1.0.0.jar apache-solr-1.4-dev/contrib/clustering/lib/pcj-1.2.jar apache-solr-1.4-dev/contrib/clustering/lib/simple-xml-1.7.3.jar
          Hide
          Grant Ingersoll added a comment -

          Hoss,

          Did you mean for clustering? if so, I fixed that, I believe, but the Release Manager will need to double check. I believe the Extraction libs are all good.

          Show
          Grant Ingersoll added a comment - Hoss, Did you mean for clustering? if so, I fixed that, I believe, but the Release Manager will need to double check. I believe the Extraction libs are all good.

            People

            • Assignee:
              Grant Ingersoll
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development