[SOLR-12964] Use advanceExact instead of advance in a few remaining json facet use cases

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.5
• Fix Version/s: 7.6
• Component/s: Facet Module
• Assignee: David Smiley
• Reporter: Tim Underwood
• Created: 06/Nov/18 04:52
• Updated: 08/Jun/19 14:57
• Resolved: 08/Nov/18 19:50

Description

This updates 2 places in the JSON Facets code that uses the advance()/docID() pattern instead of the simpler advanceExact().  Most other usages in the faceting code already make use of advanceExact().

The only remaining usage of advance() in org.apache.solr.search.facet is in:

• UniqueAgg.BaseNumericAcc.collect
• HLLAgg..BaseNumericAcc.collect

The code for those of those looks very similar and probably makes sense to update but it would require changing the return type of the protected docIdSetIterator() method to return a DocValuesIterator in order to be able to call the advanceExact() method.

Issue Links

• links to: GitHub Pull Request #493
• links to: GitHub Pull Request #493