Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12964

Use advanceExact instead of advance in a few remaining json facet use cases

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.5
    • Fix Version/s: 7.6
    • Component/s: Facet Module
    • Labels:
      None

      Description

      This updates 2 places in the JSON Facets code that uses the advance()/docID() pattern instead of the simpler advanceExact().  Most other usages in the faceting code already make use of advanceExact().

      The only remaining usage of advance() in org.apache.solr.search.facet is in:

      • UniqueAgg.BaseNumericAcc.collect
      • HLLAgg..BaseNumericAcc.collect

      The code for those of those looks very similar and probably makes sense to update but it would require changing the return type of the protected docIdSetIterator() method to return a DocValuesIterator in order to be able to call the advanceExact() method.

        Attachments

          Activity

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              tpunder Tim Underwood
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h