[SOLR-12889] Clean up CoreAdmin behavior and responses when acting on cores that failed to initialize

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 7.5
• Assignee: Unassigned
• Reporter: Shawn Heisey
• Created: 20/Oct/18 22:23
• Updated: 08/Jun/19 15:03

Description

Solr isn't behaving quite correctly when performing CoreAdmin actions on cores that exist, but failed to initialize.

• RELOAD works. That was made possible by SOLR-10021.
• UNLOAD works, and can even delete directories if asked to.
• RENAME works, but Solr must be restarted for the admin UI to reflect the new name in the "SolrCore Initialization Failures" message.
• SWAP doesn't actually work, but returns a response that LOOKS like it worked.

I didn't try the other actions, because it doesn't really make any sense to allow those on a core that failed.

What I see as things that need to be checked or implemented when acting on failed cores:

• SWAP
  • Fail fast.
  • OR make it work properly. If we choose this, adjust the core name in the initFailures part of the STATUS response.
• RENAME
  • Fail fast.
  • OR make it work properly. If we choose this, adjust the core name in the initFailures part of the STATUS response.
• UNLOAD
  • This looks like it behaves correctly. Tried it with deleteInstanceDir=true and it did wipe out the whole core.
• Other actions not already mentioned
  • Fail fast

Something else to consider: Get rid of the initFailures part of the STATUS response. List all cores, even those that failed. Include a boolean item in the response to indicate whether initialization succeeded, and only list some of the full information for a failed core. This would make implementing SOLR-12863 easier.

Issue Links

• relates to: SOLR-12863 Provide a way in the admin UI to reload cores that failed to start