[SOLR-12885] BinaryResponseWriter (javabin format) should directly copy from Bytesref to output

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.7
• Assignee: Noble Paul
• Reporter: Noble Paul
• Created: 19/Oct/18 06:44
• Updated: 21/Mar/22 20:56
• Resolved: 21/May/19 19:27

Description

The format format in which bytes are stored in BytesRef and the javabin string format are both the same. We don't need to convert the string/text fields from BytesRef to String and back to UTF8 

Now a String/Text field is read and written out as follows

luceneindex(UTF8 bytes) --> UTF16 (char[]) --> new String() a copy of UTF16 char[] -->  UTF8bytes(javabin format)

This does not add a new type to javabin. It's encoded as String in the serialized data. When it is deserialized, you get a String back

Issue Links

• is a parent of: SOLR-14013 javabin performance regressions
• is related to: SOLR-12983 JavabinLoader should avoid creating String Objects and create UTF8CharSequence fields from byte[]
• is related to: SOLR-12924 Optimize JavabinCodec to use byte[] backed CharSequence instead of String

Sub-Tasks

• Avoid creating Strings from BytesRef in ExportWriter: Closed