Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12885

BinaryResponseWriter (javabin format) should directly copy from Bytesref to output

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.7
    • Component/s: None
    • Labels:
      None

      Description

      The format format in which bytes are stored in BytesRef and the javabin string format are both the same. We don't need to convert the string/text fields from BytesRef to String and back to UTF8 

      Now a String/Text field is read and written out as follows

      luceneindex(UTF8 bytes) --> UTF16 (char[]) --> new String() a copy of UTF16 char[] -->  UTF8bytes(javabin format)

      This does not add a new type to javabin. It's encoded as String in the serialized data. When it is deserialized, you get a String back

        Attachments

        1. SOLR-12885.patch
          10 kB
          Noble Paul
        2. SOLR-12885.patch
          35 kB
          Noble Paul
        3. SOLR-12885.patch
          20 kB
          Noble Paul
        4. SOLR-12885.patch
          30 kB
          Noble Paul
        5. SOLR-12885.patch
          33 kB
          Noble Paul

          Issue Links

            Activity

              People

              • Assignee:
                noble.paul Noble Paul
                Reporter:
                noble.paul Noble Paul
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: