[SOLR-12876] un-BadApple ShardParamsTest.testGetShardsTolerantAsBool

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.6, 8.0
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 16/Oct/18 14:45
• Updated: 14/Mar/19 13:07
• Resolved: 18/Oct/18 22:18

Description

I reviewed the test itself and searched the mailing list archive for failures in the last 3 years via https://lists.apache.org/list.html?[e-mail]:lte=3y:ShardParamsTest.testGetShardsTolerantAsBool (and found no examples there but did not look elsewhere) and based on that I think the test can be un-BadApple-d.

A small change

- assertTrue(exception.getMessage().startsWith("invalid boolean value: "));
+ assertTrue(exception.getMessage(), exception.getMessage().startsWith("invalid boolean value: "));

might also be helpful. And ant beast ing of course too.