[SOLR-12753] Async logging ring buffer and OOM error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.5
• Fix Version/s: 8.1, 9.0
• Component/s: logging
• Assignee: Erick Erickson
• Reporter: Andrzej Bialecki
• Created: 07/Sep/18 16:50
• Updated: 12/May/22 00:26
• Resolved: 22/Feb/19 21:16

Description

I’m using a simulated environment for autoscaling tests, which may create some pretty degenerate cases (like collections with 50,000 replicas and Policy calculations over these, times 500 nodes).

I noticed that when I turned on debug logging I occasionally would get an OOM error, and the heap dump showed that the biggest objects were a bunch of extremely large strings in the async logger’s ring buffer. These strings were admittedly extremely large (million chars or so) but the previously used sync logging didn’t have any issue with them, because they were consumed one by one.

For sure, Solr should not attempt to be logging multi-megabyte data. But I also feel like the framework could perhaps help here by enforcing large but sane limits on maximum size of log messages.

Issue Links

• Is contained by: SOLR-12055 Enable async logging by default
• relates to: SOLR-12055 Enable async logging by default