[SOLR-12725] ParseDateFieldUpdateProcessorFactory should reuse ParsePosition

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.0
• Assignee: Andrzej Bialecki
• Reporter: Andrzej Bialecki
• Created: 31/Aug/18 09:02
• Updated: 08/Jun/19 15:03
• Resolved: 03/Oct/18 12:13

Description

ParseDateFieldUpdateProcessorFactory.parseInstant repeatedly calls all configured date parsers (DateTimeFormatter-s) for each incoming date-like field. However, it uses DateTimeFormatter.parse(dateStr) method that needs to allocate a throwaway instance of ParsePosition, instead of DateTimeFormatter.parse(dateStr, parsePosition).

Javadocs for this method suggest reusing (and reseting) a single instance of ParsePosition for multiple calls in order to reduce object allocations.