Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12690

Regularize LoggerFactory declarations

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.5, 8.0
    • Component/s: None
    • Labels:
      None

      Description

      LoggerFactory declarations have several different forms, they should all be:

      private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());

      • lowercase log
      • private static
      • non hard-coded class lookup.

      I'm going to regularize all of these, I think there are about 80 currently, we've been nibbling away at this but I'll try to do it in one go.

      Christine Poerschke I think there's another Jira about this that I can't find just now, ring any bells?

      Once that's done, is there a good way to make violations of this fail precommit?

        Attachments

        1. SOLR-12690.patch
          321 kB
          Erick Erickson
        2. SOLR-12690.patch
          318 kB
          Erick Erickson

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                erickerickson Erick Erickson
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: