LoggerFactory declarations have several different forms, they should all be:
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
- lowercase log
- private static
- non hard-coded class lookup.
I'm going to regularize all of these, I think there are about 80 currently, we've been nibbling away at this but I'll try to do it in one go.
Christine Poerschke I think there's another Jira about this that I can't find just now, ring any bells?
Once that's done, is there a good way to make violations of this fail precommit?