Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12680

Fix ClassCastException and AIOOBE in TestSolrConfigHandlerConcurrent

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 7.4
    • Fix Version/s: 7.5, 8.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Noticed some weird errors in the logs for TestSolrConfigHandlerConcurrent:

      1. Test starts a thread to change each cache listed in the query section of the config but 4 of the keys inside the query section do not contain a cache definition at all. The thread would start and immediately exit when trying to cast the long value to a Map.
      2. The second half of the invokeBulkCall method is never executed because it tried to do {{ String url = urls.get(urls.size());}} which will always result in an AIOOBE and the thread would (silently exit)
      3. The second half also contained a bug where a string was being asserted to be equal to a long object so after fixing #2 above, the test always failed.

        Attachments

        1. SOLR-12680.patch
          3 kB
          Shalin Shekhar Mangar

          Activity

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              shalinmangar Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: