[SOLR-12559] FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are involved

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.8
• Component/s: Facet Module
• Assignee: Munendra S N
• Reporter: Chris M. Hostetter
• Created: 17/Jul/18 18:11
• Updated: 09/Jan/21 16:59
• Resolved: 09/Jan/21 16:59

Description

While working on a patch dealing with json facet syntax parsing, i was trying to write a test verifying the equivalence of 2 json facet requests that should be identical and discovered that when SOLR-10613 was implemented to defer the parsing of field names via FieldNameValueSource the implementation did not account for the invocation of sub parsers via param references.

specifically – this json facet request will produce two AggValueSources which are not equals()...

curl http://localhost:8983/solr/query -d 'q=*:*&my_field=foo_i&
json.facet={
  x : "min(foo_i)",
  y : "min($my_field)"
}'

"x" uses FieldNameValueSource while "y" directly uses an IntValueSource

(It's not immediately obvious to me if this currently causes any user visible bugs or performance hicups, but it will definitely be problematic for users once we add support for min(multivalued_field_i) )

Issue Links

• is related to: SOLR-11706 JSON FacetModule can't compute stats (min,max,etc...) on multivalued fields
• is related to: SOLR-12567 Enhance JSON Facet aggregation syntax to support a JSON Object based "type:func" form that supports local params