[SOLR-12555] Replace try-fail-catch test patterns

• Type: Test
• Status: Resolved
• Priority: Trivial
• Resolution: Done
• Affects Version/s: 8.0
• Component/s: Tests
• Assignee: Jason Gerlowski
• Reporter: Jason Gerlowski
• Created: 16/Jul/18 14:32
• Updated: 05/Aug/19 05:05
• Resolved: 05/Aug/19 05:05

Description

I recently added some test code through SOLR-12427 which used the following test anti-pattern:

try {
    actionExpectedToThrowException();
    fail("I expected this to throw an exception, but it didn't");
catch (Exception e) {
    assertOnThrownException(e);
}

Hoss (rightfully) objected that this should instead be written using the formulation below, which is clearer and more concise.

SolrException e = expectThrows(() -> {...});

We should remove many of these older formulations where it makes sense. Many of them were written before expectThrows was introduced, and having the old style assertions around makes it easier for them to continue creeping in.

Issue Links

• links to: GitHub Pull Request #425
• links to: GitHub Pull Request #464