Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12549

Settle a location for the log4j2.xml file

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.5, 8.0
    • Component/s: logging
    • Labels:
      None

      Description

      CLONED from SOLR-12008 since 12008 couldn't be closed.

      As part of SOLR-11934 I started looking at log4j.properties files. Waaay back in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to use %c, but the file in "solr/example/resources/log4j.properties" was not changed. That got me to looking around and there are a bunch of log4j.properties files:

      ./solr/core/src/test-files/log4j.properties
      ./solr/example/resources/log4j.properties
      ./solr/solrj/src/test-files/log4j.properties
      ./solr/server/resources/log4j.properties
      ./solr/server/scripts/cloud-scripts/log4j.properties
      ./solr/contrib/dataimporthandler/src/test-files/log4j.properties
      ./solr/contrib/clustering/src/test-files/log4j.properties
      ./solr/contrib/ltr/src/test-files/log4j.properties
      ./solr/test-framework/src/test-files/log4j.properties

      Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I propose the logging configuration files get consolidated. The question is "how far"?

      I at least want to get rid of the one in solr/example, users should use the one in server/resources. Having to maintain these two separately is asking for trouble.

      Mark Miller Do you have any wisdom on the properties file in server/scripts/cloud-scripts?

      Anyone else who has a clue about why the other properties files were created, especially the ones in contrib?

      And what about all the ones in various test-files directories? People didn't create them for no reason, and I don't want to rediscover that it's a real pain to try to re-use the one in server/resources for instance.

        Attachments

        1. SOLR-12008.patch
          34 kB
          Erick Erickson
        2. SOLR-12008.patch
          36 kB
          Erick Erickson
        3. SOLR-12008.patch
          35 kB
          Erick Erickson
        4. SOLR-12008.patch
          35 kB
          Erick Erickson
        5. SOLR-12008.patch
          33 kB
          Erick Erickson
        6. SOLR-12008-7x-test-fail-fix.patch
          2 kB
          Erick Erickson

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                erickerickson Erick Erickson
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: