Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.4
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      Now LUCENE-1466 has been committed, Solr should use Lucene's CharFilter before release 1.4. I'll just svn del (rather than deperecated) CharFilter classes in Solr:

      $ svn status
      D      src/test/org/apache/solr/analysis/TestMappingCharFilter.java
      D      src/test/org/apache/solr/analysis/TestCharFilter.java
      D      src/java/org/apache/solr/analysis/CharReader.java
      M      src/java/org/apache/solr/analysis/CharFilterFactory.java
      D      src/java/org/apache/solr/analysis/BaseCharFilter.java
      D      src/java/org/apache/solr/analysis/CharFilter.java
      D      src/java/org/apache/solr/analysis/CharStreamAwareCJKTokenizerFactory.java
      D      src/java/org/apache/solr/analysis/CharStreamAwareWhitespaceTokenizerFactory.java
      M      src/java/org/apache/solr/analysis/MappingCharFilterFactory.java
      D      src/java/org/apache/solr/analysis/CharStreamAwareCJKTokenizer.java
      D      src/java/org/apache/solr/analysis/NormalizeMap.java
      D      src/java/org/apache/solr/analysis/MappingCharFilter.java
      D      src/java/org/apache/solr/analysis/CharStreamAwareCharTokenizer.java
      D      src/java/org/apache/solr/analysis/CharStreamAwareWhitespaceTokenizer.java
      D      src/java/org/apache/solr/analysis/CharStream.java
      M      example/solr/conf/schema.xml
      

      This needs r787795 of lucene jar or later.

      1. SOLR-1241.patch
        46 kB
        Koji Sekiguchi
      2. SOLR-1241.patch
        45 kB
        Koji Sekiguchi
      3. SOLR-1241.patch
        44 kB
        Koji Sekiguchi

        Activity

        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4
        Shalin Shekhar Mangar made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Shalin Shekhar Mangar added a comment - - edited

        Committed revision 794328.

        This has been committed as part of SOLR-940 and other related issues.

        Thanks Koji!

        Show
        Shalin Shekhar Mangar added a comment - - edited Committed revision 794328. This has been committed as part of SOLR-940 and other related issues. Thanks Koji!
        shalin committed 794328 (44 files)
        Reviews: none

        Upgraded to Lucene 2.9-dev r794238.

        Other changes include:
            LUCENE-1614 - Use Lucene's DocIdSetIterator.NO_MORE_DOCS as the sentinel value.
            LUCENE-1630 - Add acceptsDocsOutOfOrder method to Collector implementations.
            LUCENE-1673, LUCENE-1701 - Trie has moved to Lucene core and renamed to NumericRangeQuery.
            LUCENE-1662, LUCENE-1687 - Replace usage of ExtendedFieldCache by FieldCache.

        SOLR-1241: Solr's CharFilter has been moved to Lucene. Remove CharFilter and related classes from Solr and use Lucene's corresponding code.

        SOLR-1261: Lucene trunk renamed RangeQuery & Co to TermRangeQuery.

        Lucene trunk
        Koji Sekiguchi made changes -
        Attachment SOLR-1241.patch [ 12412949 ]
        Hide
        Koji Sekiguchi added a comment -

        patch updated along with the commit of SOLR-1256.

        Show
        Koji Sekiguchi added a comment - patch updated along with the commit of SOLR-1256 .
        Hide
        Shalin Shekhar Mangar added a comment -

        This ticket covers only CharFilter issue. Shalin, when you are ready to commit SOLR-940, use/commit this patch.

        I'll take care of this, thanks!

        Show
        Shalin Shekhar Mangar added a comment - This ticket covers only CharFilter issue. Shalin, when you are ready to commit SOLR-940 , use/commit this patch. I'll take care of this, thanks!
        Koji Sekiguchi made changes -
        Attachment SOLR-1241.patch [ 12411714 ]
        Hide
        Koji Sekiguchi added a comment -

        I added the diff of TokenizerChain:

        $ svn diff src/java/org/apache/solr/analysis/TokenizerChain.java >> SOLR-1241.patch
        

        We'd need to commit this together with SOLR-940 to avoid compile failures.

        Right. This ticket covers only CharFilter issue. Shalin, when you are ready to commit SOLR-940, use/commit this patch.

        Show
        Koji Sekiguchi added a comment - I added the diff of TokenizerChain: $ svn diff src/java/org/apache/solr/analysis/TokenizerChain.java >> SOLR-1241.patch We'd need to commit this together with SOLR-940 to avoid compile failures. Right. This ticket covers only CharFilter issue. Shalin, when you are ready to commit SOLR-940 , use/commit this patch.
        Hide
        Shalin Shekhar Mangar added a comment -

        Koji, the patch needs changes to TokenizerChain (add import for Lucene's CharStream/CharReader).

        We'd need to commit this together with SOLR-940 to avoid compile failures.

        Show
        Shalin Shekhar Mangar added a comment - Koji, the patch needs changes to TokenizerChain (add import for Lucene's CharStream/CharReader). We'd need to commit this together with SOLR-940 to avoid compile failures.
        Koji Sekiguchi made changes -
        Attachment SOLR-1241.patch [ 12411597 ]
        Koji Sekiguchi made changes -
        Field Original Value New Value
        Description Now LUCENE-1466 has been committed, Solr should use Lucene's CharFilter before release 1.4. I'll just svn del (rather than deperecated) CharFilter classes in Solr:

        {code}
        $ svn status
        D src/test/org/apache/solr/analysis/TestMappingCharFilter.java
        D src/test/org/apache/solr/analysis/TestCharFilter.java
        D src/java/org/apache/solr/analysis/CharReader.java
        M src/java/org/apache/solr/analysis/CharFilterFactory.java
        D src/java/org/apache/solr/analysis/BaseCharFilter.java
        D src/java/org/apache/solr/analysis/CharFilter.java
        D src/java/org/apache/solr/analysis/CharStreamAwareCJKTokenizerFactory.java
        D src/java/org/apache/solr/analysis/CharStreamAwareWhitespaceTokenizerFactory.java
        M src/java/org/apache/solr/analysis/MappingCharFilterFactory.java
        D src/java/org/apache/solr/analysis/CharStreamAwareCJKTokenizer.java
        D src/java/org/apache/solr/analysis/NormalizeMap.java
        D src/java/org/apache/solr/analysis/MappingCharFilter.java
        D src/java/org/apache/solr/analysis/CharStreamAwareCharTokenizer.java
        D src/java/org/apache/solr/analysis/CharStreamAwareWhitespaceTokenizer.java
        D src/java/org/apache/solr/analysis/CharStream.java
        M example/solr/conf/schema.xml
        {code}

        This needs r787795 or later.
        Now LUCENE-1466 has been committed, Solr should use Lucene's CharFilter before release 1.4. I'll just svn del (rather than deperecated) CharFilter classes in Solr:

        {code}
        $ svn status
        D src/test/org/apache/solr/analysis/TestMappingCharFilter.java
        D src/test/org/apache/solr/analysis/TestCharFilter.java
        D src/java/org/apache/solr/analysis/CharReader.java
        M src/java/org/apache/solr/analysis/CharFilterFactory.java
        D src/java/org/apache/solr/analysis/BaseCharFilter.java
        D src/java/org/apache/solr/analysis/CharFilter.java
        D src/java/org/apache/solr/analysis/CharStreamAwareCJKTokenizerFactory.java
        D src/java/org/apache/solr/analysis/CharStreamAwareWhitespaceTokenizerFactory.java
        M src/java/org/apache/solr/analysis/MappingCharFilterFactory.java
        D src/java/org/apache/solr/analysis/CharStreamAwareCJKTokenizer.java
        D src/java/org/apache/solr/analysis/NormalizeMap.java
        D src/java/org/apache/solr/analysis/MappingCharFilter.java
        D src/java/org/apache/solr/analysis/CharStreamAwareCharTokenizer.java
        D src/java/org/apache/solr/analysis/CharStreamAwareWhitespaceTokenizer.java
        D src/java/org/apache/solr/analysis/CharStream.java
        M example/solr/conf/schema.xml
        {code}

        This needs r787795 of lucene jar or later.
        Koji Sekiguchi created issue -

          People

          • Assignee:
            Koji Sekiguchi
            Reporter:
            Koji Sekiguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development