[SOLR-12367] When adding a model referencing a non-existent feature the error message is very ambiguous

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 7.3.1
• Component/s: contrib - LTR
• Assignee: Unassigned
• Reporter: Georg Sorst
• Created: 16/May/18 21:46
• Updated: 15/Feb/21 17:21

Description

When adding a model that references a non-existent feature a very ambiguous error message is thrown, something like "Model type does not exist org.apache.solr.ltr.model.LinearModel".

 

To reproduce, do not add any features and just add a model, for example by doing this:

 

curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store' --data-binary '

{

  "class": "org.apache.solr.ltr.model.LinearModel",

  "name": "myModel",

  "features": [ {"name": "whatever" }],

  "params": {"weights": {"whatever": 1.0}}

}' -H 'Content-type:application/json'

 

The resulting error message "Model type does not exist org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me a while to figure out the actual cause.

 

A more suitable error message should probably indicate the name of the missing feature that the model is trying to reference.

Issue Links

• is related to: SOLR-11137 LTR: misleading error message when loading a model
• is related to: SOLR-12676 Improve details on ModelException when the feature of a model has not been defined
• relates to: SOLR-15149 Learning To Rank model upload fails generically