[SOLR-12313] Removing TestInjection#waitForInSyncWithLeader

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: Cao Manh Dat
• Reporter: Mark Miller
• Created: 04/May/18 22:59
• Updated: 08/Jun/19 15:15
• Resolved: 07/Mar/19 11:26

Description

This really should have some doc for why it would be used.
I also think it causes BasicDistributedZkTest to take forever for sometimes and perhaps other tests?

I think checking for uncommitted data is probably a race condition and should be removed.

Checking index versions should follow the rules that replication does - if the slave is higher than the leader, it's in sync, being equal is not required. If it's expected for a test it should be a specific test that fails. This just introduces massive delays.

Issue Links

• is related to: SOLR-13176 Testing of TLOG Replicas needs to be re-instated, may be hiding bugs
• is related to: SOLR-12801 Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.

Sub-Tasks

• tlog replicas wait for sync on every commit when solr is run with java assertions: Closed