[SOLR-12301] Umbrella issue: paramaterize logging calls in Solr, use consistent naming conventions for the logger

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.6
• Assignee: Erick Erickson
• Reporter: Erick Erickson
• Created: 01/May/18 18:51
• Updated: 15/Jul/20 15:09
• Resolved: 09/May/20 17:35

Description

See the discussion at SOLR-12286 for a lot of background, but the short form is that logging calls of the form

log.info("somehting" + "something");
and
log.info("soemthing {}", object.someFunction());

where someFunction includes toString()

generate useless garbage/work even when the message is not printed.

log.info("somehting {}", "something");
and
log.info("soemthing {}", object);

do not. The first form is something of a relic, and there are even some uses of the second.

This will entail a LOT of changes, but almost all secretarial. I'll take it in chunks.

Issue Links

• is fixed by: LUCENE-7788 fail precommit on unparameterised log messages and examine for wasted work/objects