[SOLR-12259] Robustly upgrade indexes

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Later
• Assignee: Erick Erickson
• Reporter: Erick Erickson
• Created: 22/Apr/18 03:26
• Updated: 19/Mar/20 14:11
• Resolved: 19/Mar/20 14:10

Description

This needs more careful planning, see the SIP here: https://cwiki.apache.org/confluence/display/SOLR/SIP-2+Support+safe+index+transformations+without+reindexing

 

The general problem statement is that the current upgrade path is trappy and cumbersome. It would be a great help "in the field" to make the upgrade process less painful.

Additionally one of the most common things users want to do is enable docValues, but currently they often have to re-index.

Issues:

1> if I upgrade from 5x to 6x and then 7x, theres no guarantee that when I go to 7x all the segments have been rewritten in 6x format. Say I have a segment at max size that has no deletions. It'll never be rewritten until it has deleted docs. And perhaps 50% deleted docs currently.

2> IndexUpgraderTool explicitly does a forcemerge to 1 segment, which is bad.

3> in a large distributed system, running IndexUpgraderTool on all the nodes is cumbersome even if <2> is acceptable.

4> Users who realize specifying docValues on a field would be A Good Thing have to re-index. We have UninvertDocValuesMergePolicyFactory. Wouldn't it be nice to be able to have this done all at once without forceMerging to one segment.

Proposal:

Somehow avoid the above. Currently LUCENE-7976 is a start in that direction. It will make TMP respect max segments size so can avoid forceMerges that result in one segment. What it does not do is rewrite segments with zero (or a small percentage) deleted documents.

So it doesn't seem like a huge stretch to be able to specify to TMP the option to rewrite segments that have no deleted documents. Perhaps a new parameter to optimize?

This would likely require another change to TMP or whatever.

So upgrading to a new solr would look like
1> install the new Solr
2> execute "http://node:port/solr/collection_or_core/update?optimize=true&upgradeAllSegments=true"

What's not clear to me is whether we'd require UninvertDocValuesMergePolicyFactory to be specified and wrap TMP or not.

Anyway, let's discuss. I'll create yet another LUCENE JIRA for TMP do rewrite all segments that I'll link.

I'll also link several other JIRAs in here, they're coalescing.

Issue Links

• is related to: LUCENE-7671 Enhance UpgradeIndexMergePolicy with additional options
• is related to: SOLR-14116 Support safe index modifications without re-indexing
• is related to: LUCENE-8004 IndexUpgraderTool should rewrite segments rather than forceMerge
• is related to: LUCENE-8264 Allow an option to rewrite all segments
• is related to: LUCENE-7976 Make TieredMergePolicy respect maxSegmentSizeMB and allow singleton merges of very large segments
• is related to: LUCENE-7523 UpgradeIndexMergePolicy: beyond one-off use, monster segment avoidance
• relates to: SOLR-12940 Optimize and expunge deletes should execute only on the leader instead of all replicas of the collection
• relates to: SOLR-11127 REINDEXCOLLECTION command for re-indexing existing collections