[SOLR-12231] /etc/init.d/solr problem

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 7.3
• Component/s: scripts and tools

Environment

Centos 7.4 

java-1.8.0-openjdk

• Assignee: Steven Rowe
• Reporter: Lihua Wang
• Created: 17/Apr/18 18:05
• Updated: 08/Jun/19 15:13
• Resolved: 17/Apr/18 20:01

Description

I noticed that there are a couple of minor issues with the init.d script in pretty much every version. 

Basically, a semicolon (or an escaped semicolon) is missing in the BLUE lines blow:

 

if [ -n "$RUNAS" ]; then
su -c "SOLR_INCLUDE=\"$SOLR_ENV\" \"$SOLR_INSTALL_DIR/bin/solr\" $SOLR_CMD" - "$RUNAS"
else
SOLR_INCLUDE="$SOLR_ENV" "$SOLR_INSTALL_DIR/bin/solr" "$SOLR_CMD"
fi

 

With the added semicolons (escaped where necessary), the code would look like: 

if [ -n "$RUNAS" ]; then
su -c "SOLR_INCLUDE=\"$SOLR_ENV\"\; \"$SOLR_INSTALL_DIR/bin/solr\" $SOLR_CMD" - "$RUNAS"*
else
*SOLR_INCLUDE="$SOLR_ENV"; "$SOLR_INSTALL_DIR/bin/solr" "$SOLR_CMD"
fi