[SOLR-12154] Disallow Log4j2 explicit usage via forbidden APIs

• Type: Sub-task
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 7.4
• Assignee: Varun Thacker
• Reporter: Varun Thacker
• Created: 28/Mar/18 00:48
• Updated: 27/Jun/18 08:30
• Resolved: 04/Apr/18 01:57

Description

We need to add org.apache.logging.log4j.** to forbidden APIs

From Tomás on the reviewboard discussion ( https://reviews.apache.org/r/65888/ ) 

 We don't do log4j calls in the code in general, we have that explicitly forbidden in forbidden APIS today, and code that does something with log4j has to supress that. Developers must instead use slf4j APIs. I don't believe that's changing now with log4j2, or does it?

We need to address this before 7.4 to make sure we don't break anything by using Log4j2 directly 

After SOLR-7887 the following classes explicitly import the org.apache.logging.log4j.** package so let's validate it's usage

- Log4j2Watcher

- SolrLogLayout

- StartupLoggingUtils

- RequestLoggingTest

- LoggingHandlerTest

- SolrTestCaseJ4

- TestLogLevelAnnotations

- LogLevel