Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12142

EmbeddedSolrServer should use req.getContentWriter

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 7.4
    • None
    • None

    Description

      In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement for getContentStreams.  However, EmbeddedSolrServer still calls getContentStreams, and so clients who need to send POST data to it cannot yet switch from the Deprecated API to the new API.  The SolrTextTagger is an example of a project where one would want to do this.

      It seems EmbeddedSolrServer ought to check for getContentWriter and if present then convert it into a ContentStream somehow.  For the time being, ESS needs to call both since both APIs exist.

      CC noble.paul

      Attachments

        1. SOLR-12142.patch
          3 kB
          Noble Paul
        2. SOLR-12142.patch
          13 kB
          Noble Paul

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. SOLR-13545 ContentStreamUpdateRequest no longer closes stream

          • Major - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-11380 SolrJ must stream docs to server instead of writing to a byte[] first

          • Major - Major loss of function.
          • Closed

          Activity

            People

              noble.paul Noble Paul
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: