[SOLR-12142] EmbeddedSolrServer should use req.getContentWriter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.4
• Assignee: Noble Paul
• Reporter: David Smiley
• Created: 26/Mar/18 22:57
• Updated: 07/Aug/23 20:25
• Resolved: 08/Jun/18 22:17

Description

In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement for getContentStreams.  However, EmbeddedSolrServer still calls getContentStreams, and so clients who need to send POST data to it cannot yet switch from the Deprecated API to the new API.  The SolrTextTagger is an example of a project where one would want to do this.

It seems EmbeddedSolrServer ought to check for getContentWriter and if present then convert it into a ContentStream somehow.  For the time being, ESS needs to call both since both APIs exist.

CC Noble Paul

Issue Links

• causes: SOLR-13545 ContentStreamUpdateRequest no longer closes stream
• is related to: SOLR-11380 SolrJ must stream docs to server instead of writing to a byte[] first