Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12142

EmbeddedSolrServer should use req.getContentWriter

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4
    • Component/s: None
    • Labels:
      None

      Description

      In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement for getContentStreams.  However, EmbeddedSolrServer still calls getContentStreams, and so clients who need to send POST data to it cannot yet switch from the Deprecated API to the new API.  The SolrTextTagger is an example of a project where one would want to do this.

      It seems EmbeddedSolrServer ought to check for getContentWriter and if present then convert it into a ContentStream somehow.  For the time being, ESS needs to call both since both APIs exist.

      CC Noble Paul

        Attachments

        1. SOLR-12142.patch
          13 kB
          Noble Paul
        2. SOLR-12142.patch
          3 kB
          Noble Paul

          Issue Links

            Activity

              People

              • Assignee:
                noble.paul Noble Paul
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: