Solr
  1. Solr
  2. SOLR-1198

confine all solrconfig.xml parsing to SolrConfig.java

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      Currently , xpath evaluations are spread across Solr code. It would be cleaner if if can do it all in one place . All the parsing can be done in SolrConfig.java
      another problem with the current design is that we are not able to benefit from re-use of solrconfig object across cores.

      1. SOLR-1198.patch
        5 kB
        Noble Paul
      2. SOLR-1198.patch
        18 kB
        Noble Paul
      3. SOLR-1198.patch
        18 kB
        Noble Paul
      4. SOLR-1198.patch
        3 kB
        Noble Paul
      5. SOLR-1198.patch
        12 kB
        Noble Paul
      6. SOLR-1198.patch
        12 kB
        Noble Paul
      7. SOLR-1198.patch
        8 kB
        Noble Paul
      8. SOLR-1198.patch
        19 kB
        Noble Paul
      9. SOLR-1198.patch
        16 kB
        Noble Paul
      10. SOLR-1198.patch
        9 kB
        Noble Paul
      11. SOLR-1198.patch
        8 kB
        Noble Paul
      12. SOLR-1198.patch
        3 kB
        Noble Paul

        Issue Links

          Activity

          Hide
          Noble Paul added a comment -

          this issue can be fixed in batches. this is one low hanging fruit

          Show
          Noble Paul added a comment - this issue can be fixed in batches. this is one low hanging fruit
          Hide
          Noble Paul added a comment -

          comitted revision : 781668 with

          unlockOnStartup, useColdSearcher, maxWarmingSearchers moved to SolrConfig

          Show
          Noble Paul added a comment - comitted revision : 781668 with unlockOnStartup, useColdSearcher, maxWarmingSearchers moved to SolrConfig
          Hide
          Noble Paul added a comment -

          This moves the RequestHandler xml parsing to SolrConfig.

          This introduces a class PluginInfo which can be used for all pluggable classes

          Show
          Noble Paul added a comment - This moves the RequestHandler xml parsing to SolrConfig. This introduces a class PluginInfo which can be used for all pluggable classes
          Hide
          Noble Paul added a comment -

          tested.
          I'll commit this shortly

          Show
          Noble Paul added a comment - tested. I'll commit this shortly
          Hide
          Noble Paul added a comment -

          committed revision: 782219

          Show
          Noble Paul added a comment - committed revision: 782219
          Hide
          Noble Paul added a comment -

          moved valueSourceParser, listeners, deletionPolicy,directoryFactory,queryParser,responseWriter,
          I shall commit this shortly

          Show
          Noble Paul added a comment - moved valueSourceParser, listeners, deletionPolicy,directoryFactory,queryParser,responseWriter, I shall commit this shortly
          Hide
          Noble Paul added a comment -

          committed : r782552

          Show
          Noble Paul added a comment - committed : r782552
          Hide
          Noble Paul added a comment -

          moved updateHandler, updateprocessor to solrconfig

          Show
          Noble Paul added a comment - moved updateHandler, updateprocessor to solrconfig
          Hide
          Noble Paul added a comment -

          committed r782885

          Show
          Noble Paul added a comment - committed r782885
          Hide
          Noble Paul added a comment -

          moved searchComponent, indexReaderFactory

          Show
          Noble Paul added a comment - moved searchComponent, indexReaderFactory
          Hide
          Noble Paul added a comment -

          committed r782913

          Show
          Noble Paul added a comment - committed r782913
          Hide
          Noble Paul added a comment -

          moved highlighter

          Show
          Noble Paul added a comment - moved highlighter
          Hide
          Noble Paul added a comment -

          committed r783222

          Show
          Noble Paul added a comment - committed r783222
          Hide
          Noble Paul added a comment -

          Should it be a required feature for 1.4? My real objective is to make it possible to start solr w/o a simgle line of xml.

          Show
          Noble Paul added a comment - Should it be a required feature for 1.4? My real objective is to make it possible to start solr w/o a simgle line of xml.
          Hide
          Noble Paul added a comment -

          committed r788582 moved datadir reading to solrconfig

          Show
          Noble Paul added a comment - committed r788582 moved datadir reading to solrconfig
          Hide
          Otis Gospodnetic added a comment -

          My real objective is to make it possible to start solr w/o a simgle line of xml.

          Could you elaborate please? Where would various configuration settings be specified?

          Show
          Otis Gospodnetic added a comment - My real objective is to make it possible to start solr w/o a simgle line of xml. Could you elaborate please? Where would various configuration settings be specified?
          Hide
          Mark Miller added a comment -

          Still from the XML if you want. I think he means, by containing everything in SolrConfig, you could make a different SolrConfig impl that didnt read from XML. Or plug in Spring. Or whatever.

          Would be great to get done for 1.4, but I don't think its necessary. I think its a great idea though.

          Show
          Mark Miller added a comment - Still from the XML if you want. I think he means, by containing everything in SolrConfig, you could make a different SolrConfig impl that didnt read from XML. Or plug in Spring. Or whatever. Would be great to get done for 1.4, but I don't think its necessary. I think its a great idea though.
          Hide
          Noble Paul added a comment - - edited

          by containing everything in SolrConfig, you could make a different SolrConfig ...

          amen..

          The intent is to be able to load a core using an API. So I should be able to load my configuration from anywhere say zookeeper, a db etc etc

          But this is not very easy to squeeze this into 1.4 . so we can push it to 1.5 until we iron out the details

          But what is already done lets me share solrconfig objects and reduce core load time drastically for our massively multicore search system. ~30000 cores in a box with ~4000 cores loaded at a given time

          Show
          Noble Paul added a comment - - edited by containing everything in SolrConfig, you could make a different SolrConfig ... amen.. The intent is to be able to load a core using an API. So I should be able to load my configuration from anywhere say zookeeper, a db etc etc But this is not very easy to squeeze this into 1.4 . so we can push it to 1.5 until we iron out the details But what is already done lets me share solrconfig objects and reduce core load time drastically for our massively multicore search system. ~30000 cores in a box with ~4000 cores loaded at a given time
          Hide
          Noble Paul added a comment -

          Hi Mark , if it is Ok I shall move it to 1.5 . We should be able to clean it up completely

          Show
          Noble Paul added a comment - Hi Mark , if it is Ok I shall move it to 1.5 . We should be able to clean it up completely
          Hide
          Mark Miller added a comment -

          Yeah, no problem. I thought the scope might be less (as far as just confining the xml parsing to SolrConfig, nott being fully pluggable), but hadn't looked into it. I didn't realise you intended to go the full 9 yards with this issue. No problem here waiting till 1.5.

          Show
          Mark Miller added a comment - Yeah, no problem. I thought the scope might be less (as far as just confining the xml parsing to SolrConfig, nott being fully pluggable), but hadn't looked into it. I didn't realise you intended to go the full 9 yards with this issue. No problem here waiting till 1.5.
          Hide
          Noble Paul added a comment -

          moved PluginInfo out of solrconfig

          Show
          Noble Paul added a comment - moved PluginInfo out of solrconfig
          Hide
          Noble Paul added a comment -

          queryConverter was missed

          Show
          Noble Paul added a comment - queryConverter was missed
          Hide
          Noble Paul added a comment -

          simplified solrconfig further

          Show
          Noble Paul added a comment - simplified solrconfig further
          Hide
          Noble Paul added a comment -

          postComit, postOptimize is moved. unfortunately we do not have any testcase for this

          Show
          Noble Paul added a comment - postComit, postOptimize is moved. unfortunately we do not have any testcase for this
          Hide
          Hoss Man added a comment -

          Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

          A unique token for finding these 240 issues in the future: hossversioncleanup20100527

          Show
          Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
          Hide
          Robert Muir added a comment -

          Bulk move 3.2 -> 3.3

          Show
          Robert Muir added a comment - Bulk move 3.2 -> 3.3
          Hide
          Robert Muir added a comment -

          3.4 -> 3.5

          Show
          Robert Muir added a comment - 3.4 -> 3.5
          Hide
          Jan Høydahl added a comment -

          What's the status on this? Can it be marked as resolved, and open separate issues for remaining things?

          Show
          Jan Høydahl added a comment - What's the status on this? Can it be marked as resolved, and open separate issues for remaining things?
          Hide
          Noble Paul added a comment -

          This was resolved in 1.4

          Show
          Noble Paul added a comment - This was resolved in 1.4

            People

            • Assignee:
              Noble Paul
              Reporter:
              Noble Paul
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development