Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11754

Remove AbstractSolrTestCase

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.3
    • Component/s: Tests
    • Labels:
      None

      Description

      I'm arguing AbstractSolrTestCase should be removed as it's obsoleted by SolrTestCaseJ4.

      In SOLR-3911 (back in 2012) Mark made it extend from SolrTestCaseJ4. There is really very little in this test class. Some of the methods here are duplicated by SolrTestCaseJ4 and thus are completely redundant (ignoreException, resetExceptionIgnores, getFile). There haven't been any modifications to this class of substance since 2012 either.

      I think we can just outright remove it (no deprecation phase). Anyone still using it can trivially switch.

        Attachments

        1. SOLR-11754.patch
          38 kB
          David Smiley

          Activity

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: