Solr
  1. Solr
  2. SOLR-1153

deltaImportQuery should be honored on child entities as well

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      currently , only the root-entity can have this attribute

        Activity

        Noble Paul created issue -
        Noble Paul made changes -
        Field Original Value New Value
        Summary deltaImportQuery is should be honored on child entities as well deltaImportQuery should be honored on child entities as well
        Noble Paul made changes -
        Assignee Noble Paul [ noble.paul ]
        Hide
        Noble Paul added a comment -

        The fix ,I shall commmit this shortly

        Show
        Noble Paul added a comment - The fix ,I shall commmit this shortly
        Noble Paul made changes -
        Attachment SOLR-1153.patch [ 12408655 ]
        Hide
        Noble Paul added a comment -

        committed revision: 776958

        Show
        Noble Paul added a comment - committed revision: 776958
        Noble Paul made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Martin Davidsson added a comment -

        Thank you, Noble. Does this mean any nightly build after 5/20 has your patch applied to it?

        Show
        Martin Davidsson added a comment - Thank you, Noble. Does this mean any nightly build after 5/20 has your patch applied to it?
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4
        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Archana Reddy added a comment -

        We are facing a similar issue but out use case is nested entity.

        we have the below nested entitties

        ParentEntity
        chilld1Entity
        child2Entity.

        child1Entity is child of ParentEntity and parent of child2Entity. Child2Entity is child of child1Entity.

        when we add deltaImportQuery on child2Entity. It is not executing deltaImportQuery during delta import.
        I found that below code(#503) in the DocBuilder class is restricting the deltaImportQuery from not being executed at the nested child entity level.
        for (EntityProcessorWrapper child : epw.getChildren())

        { buildDocument(vr, doc, child.getEntity().isDocRoot() ? pk : null, child, false, ctx, entitiesToDestroy); }
        Show
        Archana Reddy added a comment - We are facing a similar issue but out use case is nested entity. we have the below nested entitties ParentEntity chilld1Entity child2Entity. child1Entity is child of ParentEntity and parent of child2Entity. Child2Entity is child of child1Entity. when we add deltaImportQuery on child2Entity. It is not executing deltaImportQuery during delta import. I found that below code(#503) in the DocBuilder class is restricting the deltaImportQuery from not being executed at the nested child entity level. for (EntityProcessorWrapper child : epw.getChildren()) { buildDocument(vr, doc, child.getEntity().isDocRoot() ? pk : null, child, false, ctx, entitiesToDestroy); }

          People

          • Assignee:
            Noble Paul
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development