[SOLR-11501] Depending on the parser, QParser should not parse local-params

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.2
• Component/s: query parsers
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 17/Oct/17 17:01
• Updated: 02/Aug/23 18:15
• Resolved: 22/Nov/17 13:50

Description

Solr should not parse local-params (and thus be able to switch the query parser) in certain circumstances. Perhaps it is when the QParser.getParser is passed "lucene" for the defaultParser? This particular approach is just a straw-man; I suspect certain valid embedded queries could no longer work if this is done incorrectly. Whatever the solution, I don't think we should assume 'q' is special, as it's valid and useful to build up queries containing user input in other ways, e.g. q= +field:value +{!dismax v=$qq}&qq=user input and we want to protect the user input there similarly from unwelcome query parsing switching.

Issue Links

• breaks: SOLR-11809 QueryComponent.prepare rq parameter parsing fails under SOLR 7.2
• causes: SOLR-16916 JSON Query DSL doesn't work if defType isn't lucene
• is related to: SOLR-4042 NullPointerException for query type 'query' without '{! ...}' syntax
• is related to: SOLR-12081 Improve docs on query parsing: embedded queries, uf (edismax)
• relates to: SOLR-14557 Unable to parse local params followed by parenthesis like {!lucene}(gigabyte)
• supercedes: SOLR-4197 EDismax allows end users to use local params in q= to override global params