Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11483

Keep more transaction log files when maxNumLogsToKeep is specified

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      We allow users to control the number of transaction log files the system should keep ( maxNumLogsToKeep ) and the number of records to keep ( numRecordsToKeep )

      However just by setting numRecordsToKeep we are not guaranteed that the system will actually keep that many records.

      This comment explains why - https://issues.apache.org/jira/browse/SOLR-6359?focusedCommentId=15214361&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15214361

      A tradeoff would be if a user explicitly specifies numRecordsToKeep and doesn't specify maxNumLogsToKeep then we should use a higher default for maxNumLogsToKeep ( say 1000 instead of 10 today )

      Off course better documentation will help so if others think this is a bad idea then we can close this out and just make sure it's documented and if users know about one parameter they will know about the other parameter as well

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                varun Varun Thacker
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: