Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11449

MoveReplicaCmd mistakenly calls registerCollectionStateWatcher instead of unregisterCollectionStateWatcher

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 7.0.1, 7.1, 8.0
    • 7.1, 8.0
    • None
    • None

    Description

      Probably got in as a copy & paste error:

      --- a/solr/core/src/java/org/apache/solr/cloud/MoveReplicaCmd.java
      +++ b/solr/core/src/java/org/apache/solr/cloud/MoveReplicaCmd.java
      @@ -206,7 +206,7 @@ public class MoveReplicaCmd implements Cmd{
             log.warn(errorString);
             results.add("failure", errorString);
             if (watcher != null) { // unregister
      -        ocmh.zkStateReader.registerCollectionStateWatcher(coll.getName(), watcher);
      +        ocmh.zkStateReader.removeCollectionStateWatcher(coll.getName(), watcher);
             }
             return;
           }
      

      Attachments

        1. SOLR-11449.patch
          9 kB
          Andrzej Bialecki

        Activity

          People

            ab Andrzej Bialecki
            ab Andrzej Bialecki
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: