Solr
  1. Solr
  2. SOLR-1139

SolrJ TermsComponent Query and Response Support

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5, 3.1, 4.0-ALPHA
    • Component/s: clients - java
    • Labels:
      None

      Description

      SolrJ should support the new TermsComponent that was introduced in Solr 1.4. It should be able to:

      • set TermsComponent query parameters via SolrQuery
      • parse the TermsComponent response
      1. SOLR-1139-WITH_SORT_SUPPORT.patch
        14 kB
        Matt Weber
      2. SOLR-1139.patch
        13 kB
        Matt Weber
      3. SOLR-1139.patch
        13 kB
        Matt Weber
      4. SOLR-1139.patch
        14 kB
        Matt Weber
      5. SOLR-1139.patch
        14 kB
        Matt Weber
      6. SOLR-1139.patch
        14 kB
        Matt Weber
      7. SOLR-1139.patch
        14 kB
        Matt Weber
      8. SOLR-1139.patch
        15 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          Matt Weber added a comment -

          This patch adds TermComponent support to SolrJ. It adds a new response TermsResponse as well as updates SolrQuery to support setting/getting of TermsComponent parameters.

          Show
          Matt Weber added a comment - This patch adds TermComponent support to SolrJ. It adds a new response TermsResponse as well as updates SolrQuery to support setting/getting of TermsComponent parameters.
          Hide
          Matt Weber added a comment -

          Added support so you can specify multiple source fields. In the previous patch I mistakenly assumed a single source field named "spell".

          Show
          Matt Weber added a comment - Added support so you can specify multiple source fields. In the previous patch I mistakenly assumed a single source field named "spell".
          Hide
          Matt Weber added a comment -

          Updated to reflect latest changes to TermsComponent in rev. 773447.

          Show
          Matt Weber added a comment - Updated to reflect latest changes to TermsComponent in rev. 773447.
          Hide
          Matt Weber added a comment -

          Here is a patch that adds support for the sort parameters in SOLR-1156.

          Show
          Matt Weber added a comment - Here is a patch that adds support for the sort parameters in SOLR-1156 .
          Hide
          Matt Weber added a comment -

          Updating patch to work with latest trunk since SOLR-1156 has been committed. Any chance of this making it into 1.4 since it is fairly trivial and the fact TermsComponent is in 1.4?

          Show
          Matt Weber added a comment - Updating patch to work with latest trunk since SOLR-1156 has been committed. Any chance of this making it into 1.4 since it is fairly trivial and the fact TermsComponent is in 1.4?
          Hide
          Yonik Seeley added a comment -

          A couple of points about testing:

          • we should avoid making tests depend on "example" so that it's easier to change in the future when we want
          • we should avoid creating entire jetty instances unless necessary - EmbeddedSolrServer should work to test basic SolrJ functionallity
          Show
          Yonik Seeley added a comment - A couple of points about testing: we should avoid making tests depend on "example" so that it's easier to change in the future when we want we should avoid creating entire jetty instances unless necessary - EmbeddedSolrServer should work to test basic SolrJ functionallity
          Hide
          Matt Weber added a comment -

          Updated test to use EmbeddedSolrServer and not depend on "example" as Yonik suggested.

          Show
          Matt Weber added a comment - Updated test to use EmbeddedSolrServer and not depend on "example" as Yonik suggested.
          Hide
          Matt Weber added a comment -

          Updated patch in preparation for SOLR-1177

          Show
          Matt Weber added a comment - Updated patch in preparation for SOLR-1177
          Hide
          Shalin Shekhar Mangar added a comment -

          Updated patch for two params added by SOLR-1625.

          I'll commit this shortly.

          Show
          Shalin Shekhar Mangar added a comment - Updated patch for two params added by SOLR-1625 . I'll commit this shortly.
          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 890053.

          Thanks Matt!

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 890053. Thanks Matt!
          Hide
          Hoss Man added a comment -

          Correcting Fix Version based on CHANGES.txt, see this thread for more details...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Show
          Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
          Hide
          Nick dos Remedios added a comment - - edited

          I'd like to know which version of the patch to use against SOLR 1.4.

          Edit - I mistakenly compiled against the 3.x branch and not 1.4.

          I tried using the latest version but when I compiled the source I got an error:

          compile-solrj:
              [javac] Compiling 3 source files to /usr/local/src/lucene-solr_3x/solr/build/solrj
              [javac] /usr/local/src/lucene-solr_3x/solr/src/solrj/org/apache/solr/client/solrj/SolrQuery.java:70: cannot find symbol
              [javac] symbol  : variable TERMS_ROWS
              [javac] location: interface org.apache.solr.common.params.TermsParams
              [javac]       this.remove(TermsParams.TERMS_ROWS);
              [javac]                              ^
          

          Sure enough in 1.4 TermsParams has no "TERMS_ROWS" field.

          I also tried the version dated "2009-12-12" but that resulted in an incomplete patch.

          Show
          Nick dos Remedios added a comment - - edited I'd like to know which version of the patch to use against SOLR 1.4. Edit - I mistakenly compiled against the 3.x branch and not 1.4. I tried using the latest version but when I compiled the source I got an error: compile-solrj: [javac] Compiling 3 source files to /usr/local/src/lucene-solr_3x/solr/build/solrj [javac] /usr/local/src/lucene-solr_3x/solr/src/solrj/org/apache/solr/client/solrj/SolrQuery.java:70: cannot find symbol [javac] symbol : variable TERMS_ROWS [javac] location: interface org.apache.solr.common.params.TermsParams [javac] this.remove(TermsParams.TERMS_ROWS); [javac] ^ Sure enough in 1.4 TermsParams has no "TERMS_ROWS" field. I also tried the version dated "2009-12-12" but that resulted in an incomplete patch.
          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1.0 release

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1.0 release

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Matt Weber
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development