[SOLR-11346] throw if solrconfig.xml <lib> is invalid

• Type: Task
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Christine Poerschke
• Created: 11/Sep/17 02:43
• Updated: 12/Sep/17 17:31

Description

This ticket proposes to throw an exception if a configured <lib> element is invalid. As janhoy mentioned on the dev mailing list today the DIH example currently only warns in this scenario e.g.

WARN ... org.apache.solr.core.SolrConfig; Couldn't add files from /Users/cpoerschke/git/solr/contrib/dataimporthandler/lib filtered by .*\.jar to classpath: /Users/cpoerschke/git/solr/contrib/dataimporthandler/lib

Instead the new behaviour would be e.g.

...
Caused by: java.nio.file.NoSuchFileException: /Users/cpoerschke/git/solr/contrib/dataimporthandler/lib
        at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
        at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
        at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
        at sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:407)
        at java.nio.file.Files.newDirectoryStream(Files.java:589)
        at org.apache.solr.core.SolrResourceLoader.getURLs(SolrResourceLoader.java:273)
        at org.apache.solr.core.SolrResourceLoader.getFilteredURLs(SolrResourceLoader.java:305)
        at org.apache.solr.core.SolrConfig.initLibs(SolrConfig.java:748)
        at org.apache.solr.core.SolrConfig.<init>(SolrConfig.java:207)
        at org.apache.solr.core.SolrConfig.readFromResourceLoader(SolrConfig.java:181)
        ...
...

if the directory does not exist but still just a warning if the directory exists but there are no matching files.