Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11336

DocBasedVersionConstraintsProcessor should be more extensible and support multiple version fields

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4
    • Component/s: None
    • Labels:
      None

      Description

      DocBasedVersionConstraintsProcessor supports allowing document updates only if the new version is greater than the old. However, if any behavior wants to be extended / changed in minor ways, the entire class will need to be copied and slightly modified rather than extending and changing the method in question.

      It would be nice if DocBasedVersionConstraintsProcessor stood on its own as a non-private class. In addition, certain methods (such as pieces of isVersionNewEnough) should be broken out into separate methods so they can be extended such that someone can extend the processor class and override what it means for a new version to be accepted (allowing equal versions through? What if new is a lower not greater number?).

        Attachments

        1. SOLR-11336.patch
          59 kB
          David Smiley
        2. SOLR-11336.patch
          53 kB
          Michael Braun
        3. SOLR-11336.patch
          52 kB
          Michael Braun
        4. SOLR-11336.patch
          44 kB
          Michael Braun
        5. SOLR-11336.patch
          33 kB
          Michael Braun

          Activity

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              mbraun688 Michael Braun
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: