Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11314

FastCharStream should avoid creating new IOExceptions as a signaling mechanism

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.6.1, 7.0, 8.0
    • 7.1, 8.0
    • None
    • None

    Description

      FastCharStream is used internally by solr query parser classes. It throws a new IOException to signal the end. However, this is quite expensive relative to most operations and it shows up very high on samples for extremely high query cases. The IOException should be a single static instance that can be shared to avoid the overhead in creation and populating the stack trace, a stack trace which is never used.

      Attachments

        Issue Links

        relates to

        Improvement - An improvement or enhancement to an existing feature or task. SOLR-11242 QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

        • Major - Major loss of function.
        • Closed

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dsmiley David Smiley
            mbraun688 Michael Braun
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment